Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add events property to Plugin defined type #11350

Merged
merged 1 commit into from Jun 20, 2023
Merged

Add events property to Plugin defined type #11350

merged 1 commit into from Jun 20, 2023

Conversation

stockiNail
Copy link
Contributor

Fix #11283

@etimberg etimberg added the type: types Typescript type changes label Jun 15, 2023
@etimberg etimberg added this to the Version 4.3.1 milestone Jun 15, 2023
@LeeLenaleee LeeLenaleee merged commit b42f9d1 into chartjs:master Jun 20, 2023
9 checks passed
@stockiNail stockiNail deleted the addEventsToPluginType branch June 28, 2023 13:08
@elinake
Copy link

elinake commented Jul 25, 2023

Fix doesn't work, because Legend does not extend Plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 4.3.1
Development

Successfully merging this pull request may close these issues.

Legend plugin is missing events property in typings
4 participants
@stockiNail @elinake @etimberg @LeeLenaleee